Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase WPM y-label range to at least 5 #93

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Increase WPM y-label range to at least 5 #93

merged 3 commits into from
Sep 30, 2023

Conversation

bolphen
Copy link
Contributor

@bolphen bolphen commented Sep 29, 2023

Fix #42.

The old "division by zero" error can be consistently triggered when one tests on a single word "aaaaaaaaaaaa" (12 a's). There will only be two wpm counts, and the error triggers if the difference is smaller than 5.

@max-niederman max-niederman self-requested a review September 29, 2023 17:50
@max-niederman
Copy link
Owner

Thanks for the fix, @bolphen!

@max-niederman max-niederman merged commit 5b33304 into max-niederman:main Sep 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-niederman max-niederman max-niederman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] divide by zero panic after exiting test
2 participants
@bolphen @max-niederman